Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debugging for uploading to pypi #736

Merged
merged 1 commit into from
May 25, 2022
Merged

Remove debugging for uploading to pypi #736

merged 1 commit into from
May 25, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented May 20, 2022

Motivation

The current deploy CI uploads the release to the testpypi repository while I made sure that the CI worked. It looks like it all works now, so this PR switches the upload target to the real pypi repository.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel May 20, 2022 02:31
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #736 (ed46d60) into dev (c14f819) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #736   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files          44       44           
  Lines        8768     8768           
  Branches     2018     2018           
=======================================
  Hits         7667     7667           
  Misses        786      786           
  Partials      315      315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14f819...ed46d60. Read the comment docs.

@rly rly merged commit 2ae871f into dev May 25, 2022
@rly rly deleted the undebug_release_ci branch May 25, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oruebel oruebel oruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rly @oruebel